Set retry limit for LastFMImporter #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Functionality seems sane, though I've not tested it myself.
To confirm the expected functionality:
Before this PR, we just repeatedly retried on http 5xx error. We never retried on 4xx error.
With this change, we now only retry LASTFM_RETRIES times if there is a 5xx page
MonkeyDo
approved these changes
Mar 15, 2021
MonkeyDo
requested changes
Mar 15, 2021
alastair
reviewed
Mar 15, 2021
alastair
reviewed
Mar 15, 2021
alastair
reviewed
Mar 15, 2021
| if (retries <= 0) { | ||
| return null; | ||
| } | ||
| await new Promise((resolve) => setTimeout(resolve, timeout)); |
There was a problem hiding this comment.
just asking a question for my information: will this just pause execution for timeout ms?
There was a problem hiding this comment.
Correct. Sort of an inline setTimeout for the async/await age.
Jest fake timers don't play well with promises and setTimeout so we replace the setTimeout function and don't have to wait for the real timeout. See jestjs/jest#7151
MonkeyDo
approved these changes
Mar 16, 2021
mayhem
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LastFMImporterused to retry indefinitely in case of errors (e.g. 50x). Further, when a page import failed, we used to move to the next page, while the previous pages continued to retry.We are now restricting the number of retries to 3. We also do not move to the next page while we are still retrying the current page.
A few tests have also been added to ensure that the retry logic works as expected.