Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Album Art Queries #2984

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Cache Album Art Queries #2984

merged 6 commits into from
Oct 10, 2024

Conversation

anshg1214
Copy link
Member

@anshg1214 anshg1214 commented Sep 20, 2024 •
edited
Loading

This PR caches all Album Art Queries using React Query.

EDIT: This PR is deployed on https://test.listenbrainz.org/

MonkeyDo
MonkeyDo reviewed Sep 22, 2024
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error when testing locally:

Query data cannot be undefined. Please make sure to return a value other than undefined from your query function. Affected query key: ["album-art","spotify:7vFC68CBMKu99p4tIz6yzx",false]

frontend/js/src/common/listens/ListenCard.tsx Outdated Show resolved Hide resolved
MonkeyDo
MonkeyDo approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working fine ! 👍

@MonkeyDo MonkeyDo merged commit c8e8efb into master Oct 10, 2024
4 of 6 checks passed
@MonkeyDo MonkeyDo deleted the ansh/cache-art-data branch October 10, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshg1214 @MonkeyDo