feat: Add Donation Flair Settings Page #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
reviewed
Oct 29, 2024
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
|
Hello @anshg1214! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
…nbrainz-server into ansh/add-donation-flair-settings
anshg1214
force-pushed
the
ansh/add-donation-flair-settings
branch
from
07c9d10
to
55b2e9c
Compare
|
I guess this is about ready to merge, what do you think? I've started working on a PR to add some CSS flairs, as you work on the username component (I checked, and it will indeed be required for some of the animations). Then we can tie it all together! |
|
Yes, this PR is ready for merge. I'll open a followup PR for adding a username component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.