Update AddData.tsx with Discord BrainzBot + tidying #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the BrainzBot Discord bot - Shortened some of the other descriptions. These could be shortened more in future. This page is useful as a reference list of tools and services that integrate with LB, not a description/advertisement of all the features they include. If we do that for every item on the page it's going to be 4x as long, hard to keep up to date, and harder for users to browse. - For similar reasons as above, I have removed the links to Foobar2000. If we link Foobar2000 then we should link every other service mentioned, which will make the page very hard to read.
MonkeyDo
requested changes
Nov 5, 2024
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
|
Thank you @MonkeyDo! Changes accepted. |
MonkeyDo
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the BrainzBot Discord bot. Additionally:
Problem
A few of the items on this page/list have long descriptions, with extra links to other services, and lists of features.
If we do that for every item on the page it's going to be 4x as long, hard to keep up to date, and harder for users to browse. Similarly, if we link Foobar2000 then we should link every other service mentioned, which will make the page very hard to read.
I suggest that this page is useful as a reference list of tools and services that integrate with LB, not a description/advertisement of all the features they include. It is more practical to maintain feature lists on the tool's page. From a UX perspective, users are more likely to be visiting this page to find what they can do with ListenBrainz + the player/s etc that they are already using. In other words, if they are not using Foobar2000, they should not need to scroll past long descriptions of Foobar2000 plugins. This applies to all players etc on this page.
Solution
Shortened some feature descriptions.
Removed the links to Foobar2000.
Action
Will need to have the tidying script run on it, thank you!