Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation build failure #3076

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix documentation build failure #3076

merged 1 commit into from
Dec 13, 2024

Conversation

samglt
Copy link
Contributor

@samglt samglt commented Dec 13, 2024

Problem

Readthedocs builds have been failing for several months, because of an issue in bleach 5.0.0's requirements:

Requested bleach==5.0.0 from [...]/requirements.txt (line 8)) has invalid metadata:
Expected matching RIGHT_PARENTHESIS for LEFT_PARENTHESIS, after version specifier
    tinycss2 (>=1.1.0<1.2) ; extra == 'css'
             ~~~~~~~~^
Please use pip<24.1 if you need to use this version.

which means changes haven't been making it to the docs for that time.

Solution

Updating bleach to 5.0.1 is the simplest fix and afterwards I was able to build the documentation locally.

Note also that bleach has been deprecated for almost two years

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, thanks for spotting this!

None of us in the team realized, and it's been ongoing for months!

@mayhem
Copy link
Member

mayhem commented Dec 13, 2024

this too needs monitoring https://tickets.metabrainz.org/browse/LB-1711

@mayhem mayhem merged commit 7053696 into metabrainz:master Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants