MeB OAuth - latest iteration #477
Conversation
Initial commit with basic HTML + CSS
so that we can use the same styles for the signup (create account) page
+ made some links real
Rename the actual tables and some changes that I missed the last time around.
security hardening by detecting code reuse, adding arbitrary fragment. improved token format. made static resources work in dev and prod.
add post method to authorization endpoint
need to look into security concerns about previous oauth attempts' data left in session. because the post data needs to be saved in session while the user is redirected to login. considered server side sessions but not sure if its enough. will probably need timestamps and some hashing to invalidate and careful checks to ensure data between two requests is not mixed. not worth the pains for now.
Test Results179 tests +112 109 ✅ +42 26s ⏱️ +17s For more details on these failures, see this check. Results for commit 7271352. ± Comparison against base commit d35a224. ♻️ This comment has been updated with latest results. |
|
I have applied the last bits of feedback to the OAuth applications pages based on the comments of the design figma We might eventually want to restyle these pages, but as aerozol commented on that figma: "Looks good, just needs to be functional" |
| <div className="form-group"> | ||
| <div className="col-md-offset-3 col-md-1"> | ||
| <a href={cancel_url} className="btn btn-default"> | ||
| Cancel | ||
| </a> | ||
| </div> | ||
| <div className="col-md-1" style={{ marginLeft: "8px" }}> | ||
| <button type="submit" className="btn btn-danger"> | ||
| Delete | ||
| </button> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
On smaller sizes the button stack up weirdly.
You can use a bootstrap btn-group instead of using col-* utilities like so:
| <div className="form-group"> | |
| <div className="col-md-offset-3 col-md-1"> | |
| <a href={cancel_url} className="btn btn-default"> | |
| Cancel | |
| </a> | |
| </div> | |
| <div className="col-md-1" style={{ marginLeft: "8px" }}> | |
| <button type="submit" className="btn btn-danger"> | |
| Delete | |
| </button> | |
| </div> | |
| </div> | |
| <div className="btn-group"> | |
| <a href={cancel_url} className="btn btn-default"> | |
| Cancel | |
| </a> | |
| <button type="submit" className="btn btn-danger" style={{ marginLeft: "8px" }}> | |
| Delete | |
| </button> | |
| </div> |
Result
No description provided.