Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding json #487

Merged
merged 14 commits into from
Oct 31, 2024
Merged

Add funding json #487

merged 14 commits into from
Oct 31, 2024

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Oct 28, 2024

Adding a funding.json file as suggested by @yvanzo: https://floss.fund/blog/announcing-floss-fund/

The metabrainz.org work should in theory be complete, since the manifest validates: https://dir.floss.fund/validate

We must add wellKnown URLs to each of the referenced projects:

metabrainz/listenbrainz-server#3017 for LB, merged.
metabrainz/bookbrainz-site#1135 for BB, merged.
metabrainz/musicbrainz-server#3397 for MB. merged.

And we must serve the wellknown files from the three projects:

https://github.com/metabrainz/openresty-gateways/pull/13/files , merged, deployed.

Copy link

github-actions bot commented Oct 28, 2024

Test Results

67 tests  ±0   67 ✅ ±0   10s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 265374b. ± Comparison against base commit c41d214.

♻️ This comment has been updated with latest results.

Co-authored-by: Nicolás Tamargo <reosarevok@metabrainz.org>
@mayhem mayhem marked this pull request as ready for review October 29, 2024 14:23
@mayhem
Copy link
Member Author

mayhem commented Oct 29, 2024

@MonkeyDo and @reosarevok : Please review the text for BB and MB and let me know if that is ok. @MonkeyDo and you seem to understand how this is all supposed to work -- can you please sanity check the technical details as well?

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to reword everything in my comments of course

metabrainz/templates/index/funding.json Outdated Show resolved Hide resolved
metabrainz/templates/index/funding.json Outdated Show resolved Hide resolved
metabrainz/templates/index/funding.json Outdated Show resolved Hide resolved
metabrainz/templates/index/funding.json Outdated Show resolved Hide resolved
metabrainz/templates/index/funding.json Outdated Show resolved Hide resolved
metabrainz/templates/index/funding.json Outdated Show resolved Hide resolved
metabrainz/templates/index/funding.json Outdated Show resolved Hide resolved
metabrainz/templates/index/funding.json Show resolved Hide resolved
mayhem and others added 7 commits October 29, 2024 16:56
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid

@mayhem mayhem merged commit a8effa3 into master Oct 31, 2024
2 checks passed
@mayhem mayhem deleted the add-funding-json branch October 31, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants