MBS-9885: Prevent setting end date for character artist #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed this for sidebar display for Created a while ago, but I missed the artist editor, and area should use Created in for consistency.
reosarevok
force-pushed
the
MBS-9885
branch
2 times, most recently
from
04bd606
to
3cb0b5d
Compare
The guidelines say that characters should never have an end date, since a character can always be reused forever once created. As such, this restricts end dates and areas for characters in the same way as we already do for genders on groups. On selecting character, this just blanks and hides the end date/area fields (including ended) rather than disabling them, since disabled fields would not actually remove dates if they were already present. Merge code and a db-level constraint will be added in subsequent commits.
Characters should never have an end date or area; this just enforces it at the database level like we do with group genders.
The way this currently works causes issues with functions like comma_list (because it inserts an unwanted message even if none is passed) and with attempts to call it recursively on its own arguments (such as a localized_note containing additional levels of localized_note variables).
reosarevok
changed the title
The guidelines say that characters should never have an end date, since a character can always be reused forever once created. As such, this restricts end dates and areas for characters when merging in the same way as we already do for genders on groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-9885
Problem
The guidelines say that characters should never have an end date, since a character can always be reused forever once created. But nothing currently stops users from entering end dates (and areas) for characters.
Solution
This restricts end dates and areas for characters in the same way as we already do for genders on groups.
On selecting character, this just blanks and hides the end date/area fields (including ended) rather than disabling them, since disabled fields would not actually remove dates if they were already present.
Testing
Manually, plus added tests similar to the ones we have for group genders.
Draft progress
dropped_columnsmechanism we already use for gender vs groups.group_type_implies_null_gender, blocking characters from having any ofend_date_year,end_date_month,end_date_day,endedandend_area.