MBS-13806: Avoid uppercasing "mi" and "mix" as Roman numerals #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reosarevok, mind taking a look? Thanks! |
derat
commented
Nov 4, 2024
reosarevok
approved these changes
Nov 5, 2024
Introduce a regular expression matching common words to exclude from "Guess case" when "Uppercased Roman numerals is checked".
derat
changed the title
|
@mwiencek, do you want to also take a look at this? |
mwiencek
approved these changes
Nov 11, 2024
mwiencek
added a commit
that referenced
this pull request
Nov 11, 2024
* master: Update POT files using the production database MBS-13806: Avoid uppercasing "mi" and "mix" as Roman numerals (#3406) Fix "Art" test filter MBS-13787: Reenable image editing Use a standard head1 DESCRIPTION for tests (#3401) Add needed file for the funding.json system to know that it can speak for musicbrainz.org (#3397) MBS-13784: Clean up dj.beatport links Use - instead of --- as a slug fallback MBS-13784: Support paid streaming for beatport
mwiencek
added a commit
that referenced
this pull request
Nov 18, 2024
* beta: Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Japanese) Translated using Weblate (Chinese (Simplified Han script)) Added translation using Weblate (Arabic) Update translation files Translated using Weblate (Japanese) Translated using Weblate (Spanish) MBS-13799: Resolve "TypeError: Object.hasOwn is not a function" (#3395) "Email sent" page is false Move common send code to `_mb_mail_service_send_single` MBS-13719: Send contact emails via new mail service MBS-13719: Add configuration options for mail-service Update POT files using the production database MBS-13806: Avoid uppercasing "mi" and "mix" as Roman numerals (#3406) Fix "Art" test filter MBS-13787: Reenable image editing Use a standard head1 DESCRIPTION for tests (#3401) Add needed file for the funding.json system to know that it can speak for musicbrainz.org (#3397) MBS-13784: Clean up dj.beatport links Use - instead of --- as a slug fallback MBS-13784: Support paid streaming for beatport Update POT files using the code changes Update Flow to 0.250.0 Update Flow to 0.249.0 Update Flow types for cookie 0.7.x Update Flow to 0.248.1 Update Flow to 0.247.1 Update Flow to 0.246.0 Update webpack to address CVE-2024-43788 Upgrade @sentry to address GHSA-593m-55hh-j8gv Update cookie JS dep to address CVE-2024-47764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBS-13806
Introduce a regular expression matching common words to exclude from "Guess case" when "Uppercase Roman numerals" is checked.
Problem
"Mi" is a common word in Spanish (and likely other languages) but also an uncommon (in album and song titles) number in Roman numerals. When "Guess case" is used while the "Uppercase Roman numerals" option is checked, titles like "Mi amor" are changed to "MI amor".
Solution
Add a regular expression matching common words that are also matched by the expression for matching Roman numerals. It currently matches "mi" and "mix" (the latter of which was already excluded from uppercasing when used in ETI).
Testing
Added a unit test case and manually tested in the edit-release form.