Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-13820: Added links to Mastodon and Bluesky in the footer #3411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Suvid-Singhal
Copy link

Problem

MBS-13820

Solution

  • Removed the Twitter URL from the footer
  • Added links to Mastodon and Bluesky in the footer

Testing

These were just minor cosmetic changes and they work fine on my test environment.

Copy link

welcome bot commented Nov 18, 2024

Thanks for opening your first pull request for MusicBrainz Server, and welcome to our community! 🎉
If you haven’t yet, please check out our contributing guidelines.
Someone will be reviewing your PR soon; just hang in there!
In the meantime, if you’re wondering what to do next, you can have a look at our issue tracker.

@brainzbot
Copy link
Member

Can one of the admins verify this patch?

@reosarevok
Copy link
Member

@brainzbot, ok to test

@yvanzo yvanzo changed the title [Fixes MBS-13820] Added links to Mastodon and Bluesky in the footer [MBS-13820] Added links to Mastodon and Bluesky in the footer Nov 19, 2024
@yvanzo yvanzo changed the title [MBS-13820] Added links to Mastodon and Bluesky in the footer MBS-13820: Added links to Mastodon and Bluesky in the footer Nov 19, 2024
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Suvid-Singhal for this contribution.

I just reformatted your pull request’s title to make it readable by our ticket-updater bot. See:

@reosarevok, I guess that we will wait for the decision to be taken in next Monday meeting before merging this change?

@reosarevok
Copy link
Member

@yvanzo: I don't think we have to - Rob already said he wanted to do this. My meeting question is not "should these be the priority" but "are we planning to quit Twitter entirely" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants