Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page for cover art processing #224

Open
wants to merge 1 commit into
base: version_3_changes
Choose a base branch
from

Conversation

twodoorcoupe
Copy link
Contributor

Summary

This is a…

  • Correction
  • Addition
  • Restructuring
  • Minor / simple change (like a typo)
  • Other

Reason for the Change

This addition is for the new image processing options.

Description of the Change

Added a sub page to "Cover Art Options" called "Cover Art Processing".

Additional Action Required

@rdswift
Copy link
Collaborator

rdswift commented Aug 12, 2024

Thanks for this. At first glance it looks good. I'll give it a closer look in the next couple of days because I'm currently out of town on vacation. One thing I might need to change is the merge target.

@rdswift rdswift changed the base branch from master to version_3_changes August 14, 2024 21:20
@rdswift rdswift added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 14, 2024
@rdswift rdswift added this to the 3.0 milestone Aug 14, 2024
@rdswift
Copy link
Collaborator

rdswift commented Aug 14, 2024

@twodoorcoupe,

Sorry to do this to you, but when you have a chance can you please rebase your change on the version_3_changes branch? We're trying to collect all the v3 changes together so that they can all be merged together into the master branch. I've updated the target branch for the PR but it now shows rolling back all the changes already applied to that branch. Thanks.

@twodoorcoupe
Copy link
Contributor Author

I hope I've done this correctly 😅

@rdswift rdswift requested a review from phw August 29, 2024 17:51
Copy link
Collaborator

@rdswift rdswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. Thanks for rebasing the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants