Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated page footer #264

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Updated page footer #264

merged 1 commit into from
Apr 2, 2023

Conversation

phw
Copy link
Member

@phw phw commented Feb 28, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Updated footer layout based on @Aerozol's design, see also https://tickets.metabrainz.org/browse/CB-448 and the screenshot below.

grafik

@phw phw requested a review from zas February 28, 2023 21:04
@Aerozol
Copy link
Contributor

Aerozol commented Feb 28, 2023

Looks slick! Would it be possible to even out the gap at the bottom and the top?
e.g. just above the Picard logo, just below '> MetaBrainz’

Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas merged commit e3af02d into metabrainz:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants