Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout added to pytest #2122

Merged
merged 2 commits into from
Jun 26, 2022
Merged

timeout added to pytest #2122

merged 2 commits into from
Jun 26, 2022

Conversation

skelly37
Copy link
Contributor

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:
    Use timeout in workflows for unit tests to prevent tests from going into an infinite loop. Admins won't need to cancel tests themselves, contributors will receive a quicker feedback.

Problem

My GSoC PR made me think that timeout in the tests is a useful feature so here it is :)

Solution

timeout-minutes set to 30, the exact value is a subject of discussion.

Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. The timeout AFAIK also only applies on inactivity (no console output), so even if we'd had a test suit that overall ran longer it should still work.

Let's merge that after fix of indentation

.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
@skelly37 skelly37 requested a review from phw June 26, 2022 10:57
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@phw phw merged commit 9c0e373 into metabrainz:master Jun 26, 2022
@skelly37 skelly37 deleted the pytest-timeout branch June 26, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants