Timeouts added to all the unit tests #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should have a bit more time preallocated than just run-tests but it also can get stuck (runs tests too), so timeout 40min should be okay.
phw
previously approved these changes
Jun 29, 2022
There was a problem hiding this comment.
I guess this is fine. That should be plenty of time and should help us finish the run earlier in case of endless loops and blocking issues. And if a run exceeds this time for some reason outside our control it would be very unusual and we can restart the process manual.
zas
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems like I've missed quite a lot of tests in my previous commit so here's the full refactored codebase (I really hope I haven't missed anything this time).
Problem
Even if tests fail, they might get stuck and won't end themselves (despite timeouts in code) after Errors, so we have to create shorter timeouts in the workflow files.
Solution
Timeouts added
Action
Nope