PICARD-2519: Allow passing supported URLs on command line

picard/tagger.py

@@ -55,6 +55,7 @@
 import shutil
 import signal
 import sys
+from urllib.parse import urlparse
 
 from PyQt5 import (
     QtCore,
@@ -321,8 +322,35 @@ def pipe_server(self):
         while self.pipe_handler.pipe_running:
             messages = [x for x in self.pipe_handler.read_from_pipe() if x not in IGNORED]
             if messages:
-                self.add_paths(messages)
-                self.bring_tagger_front()
+                self.load_to_picard(messages)
+
+    def load_to_picard(self, items):
+        files = []
+        mbids = []
+        urls = []
+
+        for item in items:
+            parsed = urlparse(item)
+            if not parsed.scheme:
+                files.append(item)
+            elif parsed.scheme == "file":
+                files.append(item.replace("file://", ''))
+            elif parsed.scheme in {"http", "https"}:
+                # .path returns / before actual link
+                urls.append(parsed.path[1:])
+            elif parsed.scheme == "mbid":
+                mbids.append(item.replace("mbid://", ''))
+
+        if files:
+            self.add_paths(files)
+            self.bring_tagger_front()
+        if urls or mbids:
+            file_lookup = self.get_file_lookup()
+            for url in urls:
+                thread.to_main(file_lookup.mbid_lookup, url, None, None, False)
+            for mbid in mbids:
+                thread.to_main(file_lookup.mbid_lookup, mbid, None, None, False)
+            self.bring_tagger_front()
 
     def enable_menu_icons(self, enabled):
         self.setAttribute(QtCore.Qt.ApplicationAttribute.AA_DontShowIconsInMenus, not enabled)
@@ -429,8 +457,7 @@ def exit(self):
 
     def _run_init(self):
         if self._cmdline_files:
-            files = [decode_filename(f) for f in self._cmdline_files]
-            self.add_paths(files)
+            self.load_to_picard([decode_filename(f) for f in self._cmdline_files])
             del self._cmdline_files
 
     def run(self):
@@ -1110,9 +1137,15 @@ def main(localedir=None, autoupdate=True):
         picard_args.stand_alone_instance,
     }
 
+    to_be_added = []
+    for x in picard_args.FILE:
+        if not urlparse(x).netloc:
+            x = os.path.abspath(x)
+        to_be_added.append(x)
+
     if not should_start:
         try:
-            pipe_handler = pipe.Pipe(app_name=PICARD_APP_NAME, app_version=PICARD_FANCY_VERSION_STR, args=[os.path.abspath(x) for x in picard_args.FILE])
+            pipe_handler = pipe.Pipe(app_name=PICARD_APP_NAME, app_version=PICARD_FANCY_VERSION_STR, args=to_be_added)
             should_start = pipe_handler.is_pipe_owner
         except pipe.PipeErrorNoPermission as err:
             log.error(err)

test/test_util_pipe.py

@@ -61,6 +61,11 @@ def test_pipe_protocol(self):
             "my_music_file.mp3",
             TestPipe.NAME, TestPipe.VERSION,
             "last-case",
+            "https://test-ca.se/index.html",
+            "file:///data/test.py",
+            "www.wikipedia.mp3",
+            "mbid://recording/7cd3782d-86dc-4dd1-8d9b-e37f9cbe6b94",
+            "https://musicbrainz.org/recording/7cd3782d-86dc-4dd1-8d9b-e37f9cbe6b94",
         )
 
         pipe_listener_handler = pipe.Pipe(self.NAME, self.VERSION)