Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-2519: Allow passing supported URLs on command line #2130

Merged
merged 31 commits into from
Jul 31, 2022
Merged

PICARD-2519: Allow passing supported URLs on command line #2130

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e5b35cd
tests added
skelly37 Jul 20, 2022
af76417
Merge branch 'metabrainz:master' into url
skelly37 Jul 20, 2022
b6e98ae
added missing test
skelly37 Jul 20, 2022
44e9670
separated logic
skelly37 Jul 20, 2022
a56da66
base logic works, tho:
skelly37 Jul 20, 2022
ff09be4
unused import
skelly37 Jul 20, 2022
e8bce2b
events sent to main, works fine
skelly37 Jul 21, 2022
601786b
mbid:// added, slightly refactored
skelly37 Jul 21, 2022
ad4e634
Merge branch 'master' into url
skelly37 Jul 21, 2022
1dcf5fa
included new functionality in our test cases + re-run github actions
skelly37 Jul 21, 2022
413afd3
file append
skelly37 Jul 21, 2022
7250003
mbid netloc + path
skelly37 Jul 21, 2022
8fa8913
load sets instead of lists
skelly37 Jul 21, 2022
9593303
file://
skelly37 Jul 21, 2022
e42e4d0
FILE -> FILE_OR_URL in picard cli args
skelly37 Jul 21, 2022
c440f23
Merge branch 'metabrainz:master' into url
skelly37 Jul 22, 2022
962b25a
Merge branch 'metabrainz:master' into url
skelly37 Jul 24, 2022
0ba6a19
moved to-be-added
skelly37 Jul 24, 2022
c1e2f6c
arguments parsing and loading split into separate methods, alphabetic…
skelly37 Jul 24, 2022
8cfaede
method renamed, tests added
skelly37 Jul 24, 2022
8aca6d9
typo fix
skelly37 Jul 24, 2022
7dad643
typo fix v2
skelly37 Jul 24, 2022
74581db
test enhancements
skelly37 Jul 24, 2022
5f6dda9
changes
skelly37 Jul 24, 2022
56b54a3
Tagger._parse_items_to_load() -> ParseItemsToLoad class
zas Jul 24, 2022
62cf581
Merge pull request #3 from zas/ParseItemsToLoad
skelly37 Jul 24, 2022
4c77621
unionize mbids and urls
skelly37 Jul 25, 2022
3884612
help aded
skelly37 Jul 25, 2022
a28417c
Merge branch 'url' of https://github.com/skelly37/picard into url
skelly37 Jul 25, 2022
0416650
ParseItemsToLoad: add __bool__() and use it to bring tagger to front
zas Jul 27, 2022
1aa27aa
Merge pull request #4 from zas/ParseItemsToLoadBool
skelly37 Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion picard/tagger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def load_to_picard(self, items):
if not parsed.scheme:
files.append(item)
elif parsed.scheme == "file":
files.append(item.replace("file://", ''))
files.append(parsed.path)
zas marked this conversation as resolved.
Show resolved Hide resolved
elif parsed.scheme in {"http", "https"}:
# .path returns / before actual link
urls.append(parsed.path[1:])
Expand Down