Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more languages #35

Closed
wants to merge 56 commits into from
Closed

Conversation

ashpect
Copy link
Contributor

@ashpect ashpect commented Aug 27, 2024

Fixing #33 's bugs one by one.

  • node
  • py
  • ruby
  • java
  • cobol
  • ts
  • [] go
  • [] rust

@ashpect
Copy link
Contributor Author

ashpect commented Aug 27, 2024

Will need to refactor test workflow to avoid getting space limited.

@viferga
Copy link
Member

viferga commented Aug 27, 2024

The CI is failing and there are conflicts, should I merge this...?

@viferga viferga marked this pull request as draft August 27, 2024 22:18
@ashpect
Copy link
Contributor Author

ashpect commented Aug 27, 2024

Fixing #33 's bugs one by one.

  • node
  • py
  • ruby
  • java
  • cobol
  • ts
  • [] go
  • [] rust

Not now, when I fix the remaining 2 languages, then we can merge. I'll edit it to a WIP pr

@ashpect ashpect changed the title Add support for more languages [WIP] Add support for more languages Aug 27, 2024
@viferga
Copy link
Member

viferga commented Aug 27, 2024

Amazing, great job @ashpect .

@viferga viferga marked this pull request as ready for review August 27, 2024 22:24
@ashpect ashpect changed the title [WIP] Add support for more languages Add support for more languages Oct 6, 2024
@ashpect
Copy link
Contributor Author

ashpect commented Oct 6, 2024

Mergable.
Opened issues for remaining languages, ie , go and rust

Fixing #33 's bugs one by one.

  • node
  • py
  • ruby
  • java
  • cobol
  • ts
  • [] go
  • [] rust

Not now, when I fix the remaining 2 languages, then we can merge. I'll edit it to a WIP pr

@ashpect ashpect mentioned this pull request Oct 6, 2024
10 tasks
@viferga
Copy link
Member

viferga commented Oct 9, 2024

@ashpect I see the startup test is still failing, are we able to merge and delay this feature, or you are going to implement it?

@ashpect
Copy link
Contributor Author

ashpect commented Oct 10, 2024

@Error : DynLink error: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.38' not found (required by /lib/x86_64-linux-gnu/libicui18n.so.72) [Sun Oct 6 02:50:46] #7 @error : Failed to load library from plugin descriptor [Sun Oct 6 02:50:46] #7 @error : Plugin loader from manager 'loader' failed to load plugin: node [Sun Oct 6 02:50:46] #7 @error : Failed to create loader: node [Sun Oct 6 02:50:46] #7 @error : Tried to load 1 file(s) from non existent loader (node): /usr/local/lib/plugins/cli/internal/cli_cmd_plugin/cli_cmd_plugin.js [Sun Oct 6 02:50:46] #7 @error : Loader load from configuration invalid load from file [Sun Oct 6 02:50:46] #7 @error : Failed to load plugin: /usr/local/lib/plugins/cli/internal/cli_cmd_plugin/metacall.json Failed to load CLI plugins from folder '/usr/local/lib/plugins/cli/internal' with result: 4'`

Yes, there is some error. I'll check once by triggering them seperately to see which language failed

@ashpect
Copy link
Contributor Author

ashpect commented Oct 10, 2024

it is failing dev to Cobol

@ashpect
Copy link
Contributor Author

ashpect commented Oct 10, 2024

@viferga To prevent confusion, I'm closing this Pr and closed the previous one. I've opened an issue mentioning the status of the languages supported [i,e 6/10] and also a small PR uncommenting java and wasm. I think it's better to start fresh with the remaining 4 to avoid confusion and avoid getting stale.

@ashpect ashpect closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants