Update tests in win32.

metacall · Sep 6, 2023 · d07d5e1 · d07d5e1
1 parent f560eb8
commit d07d5e1
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/source/loaders/file_loader/source/file_loader_impl.c b/source/loaders/file_loader/source/file_loader_impl.c
@@ -47,7 +47,7 @@
 	#endif
 
 	#include <windows.h>
-	#include <sys/stat.h>
+	#include <sys/stat.h> /* Apparently it is supported on newer windows standards */
 
 typedef struct _stat file_stat_type;
 
@@ -67,7 +67,7 @@ typedef struct stat file_stat_type;
 
 #endif
 
-/* Support for glob, only in POSIX for now */
+/* Support for glob, only in POSIX for now (TODO: Implement Windows support) */
 #if !defined(_WIN32) &&                                                                     \
 	(defined(unix) || defined(__unix__) || defined(__unix) ||                               \
 		defined(linux) || defined(__linux__) || defined(__linux) || defined(__gnu_linux) || \

diff --git a/source/ports/rb_port/CMakeLists.txt b/source/ports/rb_port/CMakeLists.txt
@@ -9,7 +9,7 @@ endif()
 include(Portability)
 
 if(PROJECT_OS_FAMILY STREQUAL win32 OR PROJECT_OS_FAMILY STREQUAL macos)
-	message(WARNING "rb_port does not work on Windows neither MacOS")
+	message(WARNING "Port rb_port does not work on Windows neither MacOS")
 	return()
 endif()
 

diff --git a/source/tests/metacall_file_test/CMakeLists.txt b/source/tests/metacall_file_test/CMakeLists.txt
@@ -3,6 +3,16 @@ if(NOT OPTION_BUILD_LOADERS OR NOT OPTION_BUILD_LOADERS_FILE OR NOT OPTION_BUILD
 	return()
 endif()
 
+# TODO: This test is not passing properly in Windows.
+# Glob is not implemented properly on the file_loader for Windows,
+# so we disable it until we support glob properly.
+include(Portability)
+
+if(PROJECT_OS_WIN)
+	message(WARNING "Loader file_loader with glob support does not work on Windows with MSVC compiler")
+	return()
+endif()
+
 #
 # Executable name and options
 #