Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Fix typos & grammatical errors #473

Merged
merged 1 commit into from
Dec 23, 2023
Merged

nit: Fix typos & grammatical errors #473

merged 1 commit into from
Dec 23, 2023

Conversation

claddyy
Copy link

@claddyy claddyy commented Dec 18, 2023

Description

This PR aims to fix a few typos, and grammatical errors in:

  • README.md in the root directory.
  • README.md for docs dir.

Type of change

  • Documentation update

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
  • I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
  • I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
  • I have tested with Helgrind in case my code works with threading.
  • I have run make clang-format in order to format my code and my code follows the style guidelines.

If you are unclear about any of the above checks, have a look at our documentation here.

@claddyy
Copy link
Author

claddyy commented Dec 18, 2023

I'm not sure why the Tests are failing, even though I didn't touch any code.
There might be an issue with the Tests. Please let me know, how this can be solved from my side(If possible)

@giarve giarve merged commit 34b2842 into metacall:develop Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants