Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux CI Repository Dispatch Test added #509

Merged
merged 10 commits into from
Jul 23, 2024

Conversation

shaggyyy2002
Copy link
Contributor

@shaggyyy2002 shaggyyy2002 commented Jun 15, 2024

Description

In this I have added the repository dispatch so that it will trigger the linux-dist repo, only if it passes all the linux tests mentioned.

Fixes #505 Connect Core CI with Distributable's Repo

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
  • [ X I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
  • [ X I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
  • I have tested with Helgrind in case my code works with threading.
  • I have run make clang-format in order to format my code and my code follows the style guidelines.

In this I have added the repository dispatch so that it will trigger the windows-dist repo, only if it passes all the windows tests mentioned
@shaggyyy2002 shaggyyy2002 changed the title Shaggyyy2002 linux ci 1 Linux CI Repository Dispatch Test added Jun 15, 2024
@viferga
Copy link
Member

viferga commented Jun 19, 2024

I am going to merge this once this is fixed: #504

I am going to merge the PR because the problem has been solved, but there is a new bug I have to figure out. Once this is finished I will tag a new version and merge this.

@viferga viferga merged commit ffe0b97 into metacall:develop Jul 23, 2024
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect Core CI with Distributable's Repo
2 participants