Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented uninstall parameter flag for install.ps1 script for Windows #32

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Implemented uninstall parameter flag for install.ps1 script for Windows #32

merged 15 commits into from
Nov 19, 2024

Conversation

SaranshBaniyal
Copy link
Contributor

  • Implemented uninstall parameter to install.ps1 script for Windows
  • Created Uninstall function which removes the metacall data from InstallDir and removes MetaCall from Environment Path Variable

@viferga
Copy link
Member

viferga commented Nov 11, 2024

In order to approve the PR, it needs the following:

  1. Add tests for verifying that uninstall works. You can do it in the windows CI.
  2. Use properly tabs for indentation.
  3. Set uninstall flag by default to false.

Until this is solved, I am leaving the PR as draft.

@viferga viferga marked this pull request as draft November 11, 2024 21:08
@viferga
Copy link
Member

viferga commented Nov 13, 2024

@SaranshBaniyal I added tests.. and it seems the uninstall fails, can you review it?

@SaranshBaniyal
Copy link
Contributor Author

@viferga sure sir, I'll look into it

@viferga viferga marked this pull request as ready for review November 19, 2024 20:48
@viferga viferga merged commit 6ff2764 into metacall:master Nov 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaranshBaniyal @viferga