Handle CallWithFlashbotsSignature returning non-JSONRPC error #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the
CallWithFlashbotsSignature
receiver returns JSON that is neither a JSONRPC response or the{"error":"some error"}
format, thenCallWithFlashbotsSignature
will returnnil, nil
.This adds a new
TestCallWithFlashbotsSignature
that exhibits the issue, as well as a fix: after unmarshaling the response, we check that theid
andjsonrpc
fields are set correctly, if they aren't we can assume that the response was non-JSONRPC (and was also not aRelayErrorResponse
since that path was already checked as well.This could happen if for example the relay returns a JSON payload alongside a HTTP error, so I included the HTTP status code in the returned error.