Added new script and mapping for Debian package name mapping #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
requested changes
May 12, 2017
lib/MetaCPAN/Script/Debian.pm
Outdated
| use List::MoreUtils qw( uniq ); | ||
| use CPAN::DistnameInfo; | ||
| use Email::Simple (); | ||
| use Email::Sender::Simple (); |
There was a problem hiding this comment.
Can we alpha sort these and not implicitly import? ie use DBI ();
lib/MetaCPAN/Script/Debian.pm
Outdated
| is => 'ro', | ||
| isa => Str, | ||
| lazy => 1, | ||
| builder => '_build_host_rx', |
lib/MetaCPAN/Script/Debian.pm
Outdated
| } | ||
| else { | ||
| push @failures => [ $source, $url ], | ||
| ; |
There was a problem hiding this comment.
That semicolon should be on the previous line. I think the extra comma is messing things up.
We want to provide the distribution name mappings for Perl packages to 3rd party sources like Debian. This commit adds the 'external_package' mapping, and starts with adding the entry for 'debian' + the script to populate the data.
mickeyn
force-pushed
the
mickey/dist_3rd_party_packages
branch
from
2b4e340 to
3dfdfd7
Compare
oalders
approved these changes
May 12, 2017
book
added a commit
to book/CPANio
that referenced
this pull request
May 17, 2017
The history is: - metacpan/metacpan-api#634 - metacpan/metacpan-api#637 The addition to MetaCPAN as a new set of metadata will enable the further addition of more external package listings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to provide the distribution name mappings for Perl
packages to 3rd party sources like Debian.
This commit adds the 'external_package' mapping, and starts
with adding the entry for 'debian' + the script to populate
the data.