Skip to content

Add newuser blurb to landing page #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2021

Conversation

PaulGWebster
Copy link
Contributor

@PaulGWebster PaulGWebster commented Sep 23, 2021

Please test this where required I really do not do frontend... I tried to generate the css changes with this command:

/home/paul/Work/metacpan-docker/src/metacpan-web/root/static/less: lessc style.less > global.less

This caused an error about .border-radius not being defined, the internet said to change this to border-radius: N, which I did but indeed not sure of the real effect of this!

@oalders oalders requested a review from haarg September 23, 2021 15:41
@haarg
Copy link
Member

haarg commented Sep 23, 2021

You don't need to regenerate the CSS. That is done automatically when the server is started.

Can you remove all the CSS changes aside from what is related to the front page addition?

@haarg
Copy link
Member

haarg commented Sep 23, 2021

The easiest way to get lessc working is by running yarn install. Alternatively, you can install lessc globally and add an entry like:

lessc_command = lessc

to metacpan_web_local.conf.

@PaulGWebster
Copy link
Contributor Author

You don't need to regenerate the CSS. That is done automatically when the server is started.

Can you remove all the CSS changes aside from what is related to the front page addition?

that was the thing ... it did not auto generate on server start which forced me to go looking how to generate it :)

@PaulGWebster
Copy link
Contributor Author

PaulGWebster commented Sep 23, 2021

I have just pushed the css file that is required for the text only, seems all good perhaps I had it cached not sure!

I miss the days there was just a style.css :|

root/home.tx Outdated
@@ -37,5 +37,6 @@
<button class="btn search-btn help-btn">?</button>
</div>
</form>
<p class="helper_blurb">Just getting started with perl? Try these <a target="_blank" rel="noopener" href="https://www.perl.org/learn.html">free learning resources</a> from the Perl community</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just getting started with perl?

Should that be Perl rather than perl? We're referring to the language rather than the interpreter here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to Perl

Fixed capitalization error on Perl
Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PaulGWebster!

@oalders oalders merged commit 4bec4d0 into metacpan:master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants