Add typescript build test #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zewa666
suggested changes
May 30, 2018
package.json
Outdated
| "compile:samples": "tsc output/arithmetics.ts output/css.ts output/json.ts output/javascript.ts output/st.ts output/arithmetics-typed.ts", | ||
| "lint:samples": "tslint output/*.ts", | ||
| "compile:samples": "tsc --declaration output/arithmetics.ts output/css.ts output/json.ts output/javascript.ts output/st.ts output/arithmetics-typed.ts", | ||
| "lint:samples": "tslint `find output -not -iname *.d.ts -iname *.ts`", |
There was a problem hiding this comment.
instead of this we could add the following to the tslint.json file, which is supported since v5.8
"linterOptions": {
"exclude": [
"output/*d.ts"
]
}| @@ -923,7 +923,7 @@ function generateTS(ast, options) { | |||
|
|
|||
| if (options.trace) { | |||
| parts.push([ | |||
| "interface ITraceEvent {", | |||
| "export interface ITraceEvent {", | |||
|
@zewa666 Yes that is a good catch. That interface is produced conditionally if caching is enabled. It would seem none of the current tests exercise that option. |
|
Thank you guys! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed npm script so that typescript compiler generates declaration files. This causes the build to fail for classes and interfaces that are not properly exported.
Added an export to the typescript template code that was missed by previous fix.
Changed the tslint script to exclude declaration files.