Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peggy dependencies version #62

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

kamiazya
Copy link
Contributor

@kamiazya kamiazya commented Jun 6, 2021

The version of peggy is fixed by peerDependencies and dependencies.

What was a problem

Currently, when I try to use the latest version of peggy@1.2.0, the following worning is displayed.

warning "> ts-pegjs@1.0.0" has incorrect peer dependency "peggy@1.1.0".

How this PR fixes the problem

Fixed peggy's 1.1.0 <=, <2.0.0 range to be supported using^.

Additional Comments

I had an idea to set peerDependencies to ^1.0.0 and dependencies to^1.2.0, but I left the version specification as it is.

@pjmolina pjmolina merged commit f7a172a into metadevpro:master Jul 2, 2021
@pjmolina
Copy link
Contributor

pjmolina commented Jul 2, 2021

Hi @kamiazya found a breaking change for ts-peg into peggy 1.2.0 that forced me to copy code into ts-peg 1.1.0.

  • Functions stringEscape() and regexpClassEscape() used to be public, now are private. I will report it in peggy.
  • It could be nice for peggy to keep exposing the public functionality as it is not to break pluggins.
  • That's why I preffer dependences and peerDependences not to use the caret.

See my fix here: 933f2fe

@kamiazya
Copy link
Contributor Author

kamiazya commented Jul 2, 2021

Hi @pjmolina ,

Thank you for the report and fixes.

I'm sorry I didn't notice the breaking change.

@kamiazya kamiazya deleted the kamiazya-patch-2 branch July 2, 2021 08:24
@pjmolina
Copy link
Contributor

pjmolina commented Jul 2, 2021

No problem. Issue reported at peggy 169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants