-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can MarcXmlHandler drop namespace guard for record elements? #330
Comments
@blackwinter feel encouraged to improve it ! |
Thx a lot! It will be part of the new release. |
Great, thanks :) |
This came up in a conversation with hbz/Verbundgruppe. The want to use the cli tool and want a workflow usable for records with as well without namespace. They also do not want to adjust the workflow for every data provider.
But it does not with records with namespaces. @blackwinter am I missing something. Your commit seems to suggest that this is somehow possible. |
I'm sorry, I don't understand. Where does your second example include records with namespaces? |
Thanks, I updated the link. Here is the example with namespace too. |
So you mean that you can't use |
Correct. We need to decide how to support this. Should I open a ticket to support this? Or is it a better idea to introduce an boolean-option that turns this test off? |
IDK. The first option would be a general improvement with potentially more widespread applicability, while the second would be a limited enhancement for this particular handler (and also redundant from an API perspective). So I guess I'm leaning towards the former, but I have no idea how difficult it would be to implement. |
Records are only recognized if the element's tag name equals
record
and the element's namespace URI equalshttp://www.loc.gov/MARC21/slim
. However, at least Alma produces MARCXML without any namespace (xmlns
), which MarcXmlHandler cannot process. There's no apparent workaround short of manipulating the XML files before processing.Seeing as the record element is the only element that is restricted by namespace, it's unclear why this check was introduced in the first place (the commit doesn't provide any clues). All tests pass without it.
The text was updated successfully, but these errors were encountered: