-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ignoring namespace guard for handle-marcxml
in flux
#569
Comments
Value |
Are you saying that we should derive meaning from an opaque string just because of limitations in the grammar specification? Are you also saying that it should only apply to the In that case, I would very much prefer to introduce another option to disable the namespace check (boolean). I probably shouldn't have done it this way to begin with. |
At this point I see them as guardrails.
I vote for this.
As your implementation is useful only to programmers I think they will cope with it. But of course it would have been the best to implement something that can be also used by |
I'm sorry, but I don't follow this line of argument. You would still need to document what |
Setting "ignorenamespace" to "true" ignores checking the namespace.
Even if a namespace is set after setting "ignorenamespace" to "true" the namespace is ignored.
Should I test this feature? |
Yeah - you can give it a test. I thought this functionality too simple to need a functional review but it doesn't hurt of course. |
@blackwinter introduced the possibility to turn off the namespace guard with
handle-marcxml
but at the moment it only works in Java due to setting the optionnamespace=null
. Assiningnull
is not possible in FLUX.Correct. We need to decide how to support this. Should I open a ticket to support this? Or is it a better idea to introduce an boolean-option that turns this test off?
Originally posted by @TobiasNx in #330 (comment)
hbz/Verbundgruppe has the usecase to use the same workflow for transformation marcxml WITH and WITHOUT namespace. This would require this enhancement.
The text was updated successfully, but these errors were encountered: