Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-LD keywords in input data break _else pass-through in morph #343

Closed
fsteeg opened this issue Nov 24, 2020 · 1 comment · Fixed by #344
Closed

JSON-LD keywords in input data break _else pass-through in morph #343

fsteeg opened this issue Nov 24, 2020 · 1 comment · Fixed by #344
Assignees
@blackwinter
Labels
Bug

Comments

@fsteeg
Copy link
Member

fsteeg commented Nov 24, 2020

Somehow data input field names like @id, @graph end up in morph feedback/recursion and are missing in the output. This came up in https://gitlab.com/oersi/oersi-etl/-/issues/29#note_453341447 and I've implemented a fix for metafacture-fix in metafacture/metafacture-fix@f4dc31d. I'll branch off from #342 to add a test case for metamorph.
fsteeg added a commit that referenced this issue Nov 24, 2020
@fsteeg
Add JSON-LD keyword to sample _else test data
4e2398e 
See #343
@fsteeg
Copy link
Member Author

fsteeg commented Nov 24, 2020

Added test case (see 4e2398e) to reproduce:

git fetch
git checkout 343-keywordsElse
./gradlew check

@fsteeg fsteeg added the Bug label Nov 24, 2020
fsteeg referenced this issue in metafacture/metafacture-fix Nov 24, 2020
@fsteeg
Don't trigger feedback/recursion on JSON-LD keywords
f4dc31d 
See https://gitlab.com/oersi/oersi-etl/-/issues/29
@blackwinter blackwinter self-assigned this Nov 26, 2020
blackwinter added a commit that referenced this issue Nov 26, 2020
@blackwinter
Escape feedback char in _else data.
c59096a 
Fixes #343.
@blackwinter blackwinter mentioned this issue Nov 26, 2020
Merged
fsteeg added a commit to metafacture/metafacture-fix that referenced this issue Dec 1, 2020
@fsteeg
Adopt solution by @blackwinter for @ feedback issue
e1117dc 
See:

f4dc31d
metafacture/metafacture-core#343
metafacture/metafacture-core#344
fsteeg added a commit to metafacture/metafacture-fix that referenced this issue Dec 1, 2020
@fsteeg
Adopt solution by @blackwinter for @ feedback issue
34479e8 
See:

f4dc31d
metafacture/metafacture-core#343
metafacture/metafacture-core#344
@dr0i dr0i closed this as completed in 15c29d9 Apr 19, 2021
blackwinter pushed a commit that referenced this issue Dec 13, 2024
@dr0i
Bump java version from 8 to 11 (#343)
8c9789a 
Consumes the rc from metafacture-core which also uses java 11.
See #515 .
blackwinter pushed a commit that referenced this issue Dec 13, 2024
@dr0i
Revert metafacture-core dependency and metafacture-fix version number (…
4f2f19e 
…#343)

Reverts 8c9789a in part.
blackwinter pushed a commit that referenced this issue Dec 13, 2024
@dr0i
Bump java version from 8 to 11 (#343)
828617b 
Consumes the rc from metafacture-core which also uses java 11.
See #515 .
blackwinter added a commit that referenced this issue Dec 13, 2024
@blackwinter
Switch profiling from HPROF to Java Flight Recorder.
8ea116a 
After the switch to Java 11 (#343), the JVM TI hprof Agent (introduced in e144936) is no longer available (removed in JDK 9, see https://bugs.openjdk.org/browse/JDK-8046661).

Use the `jfr` command-line tool or JDK Mission Control (https://jdk.java.net/jmc/) to analyze the recording file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackwinter blackwinter

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape feedback char in _else data. metafacture/metafacture-core
2 participants
@blackwinter @fsteeg