Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AbstractLookup.java and AbstractCompose.java to helpers? #365

Closed
TobiasNx opened this issue May 11, 2021 · 1 comment
Closed

Move AbstractLookup.java and AbstractCompose.java to helpers? #365

TobiasNx opened this issue May 11, 2021 · 1 comment

Comments

@TobiasNx
Copy link
Contributor

AbstractCompose.java and
AbstractLookup.java sit in the functions folder while the other "abstract"-helpers reside in https://github.com/metafacture/metafacture-core/blob/6f3a197ae99a77f00f17d69edb825365ba5a9fce/metamorph-api/src/main/java/org/metafacture/metamorph/api/helpers/

Is that intentional, should we move them?

@fsteeg
Copy link
Member

fsteeg commented May 11, 2021

As discussed in the standup today: I think the way it is makes sense, since the classes in the functions package relate to specific functions. Also, this would be a breaking change which we can only introduce in a major version.

@fsteeg fsteeg closed this as completed May 11, 2021
blackwinter added a commit that referenced this issue Dec 13, 2024
blackwinter pushed a commit that referenced this issue Dec 13, 2024
Add new fix method to set variable with element value #282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants