Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Flux HelpPrinter content #367

Open
3 tasks
fsteeg opened this issue Jun 1, 2021 · 5 comments
Open
3 tasks

Improve Flux HelpPrinter content #367

fsteeg opened this issue Jun 1, 2021 · 5 comments
Assignees

Comments

@fsteeg
Copy link
Member

fsteeg commented Jun 1, 2021

This is part of metafacture/metafacture.github.io#10

Improve content of HelpPrinter.java:

  • Group commands by type (Readers, Decoders, Encoders, Writers)
  • Explain signatures (a general explanation about how to read signatures like String -> StreamReceiver or specific translations like "Reads from a string and writes to a stream receiver" or "Expects strings as input and produces metadata events")
  • Add missing options
@TobiasNx
Copy link
Contributor

TobiasNx commented Jul 14, 2021

It would be nice if you link to the code of a function too
.

@blackwinter
Copy link
Member

blackwinter commented Oct 13, 2021

Could you elaborate a little?

Group commands by type

What is a command's type?

Explain signatures

What might such an explanation look like?

Add missing options

Which options are missing?

I would maybe add:

  • Sort options alphabetically
  • List signature before options
  • Add (mandatory and optional) arguments via Class.getConstructors() (instead of @ReturnsAvailableArguments annotation?)

And as a slight variation of @TobiasNx's suggestion:

  • Link to class's Javadoc
  • Maybe even: Link to option's (i.e., setter's) Javadoc

@fsteeg
Copy link
Member Author

fsteeg commented Oct 14, 2021

Could you elaborate a little?

I've added some details to the original issue description.

@blackwinter
Copy link
Member

@dr0i: You checked the task for "Link to class's Javadoc" in my comment, but the recent changes (#509) only link to the source code, not the Javadoc.

@dr0i
Copy link
Member

dr0i commented Nov 28, 2023

@blackwinter oh, right - I thought of the javadoc comments in the classes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants