Handle not-normalized Pica+ #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be backwards compatible as the default is still the normalized serialization. - add LineRecorder to split non-normalized serialized PICA+ records - add testing of LineRecorder - add flux example - add flux command See #296.
Avoid reassignment to static fields, keep switch in parser See #296
|
Merged, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #297 to hopefully make Travis build work.
With added changes as discussed offline (switch to enum for PicaConstants).
Resolves #296.
Otherwise +1 for the original content. Feel free to merge if you and Travis are happy, @dr0i.