Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another name to flux command "stream-to-xml" #310

Merged
merged 2 commits into from
Oct 24, 2019

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Sep 30, 2019

This name points to SimpleXmlEncoder.
Keeping the old name for compatibility reasons.

See #308.

This name points to SimpleXmlEncoder.
Keeping the old name for compatibility reasons.

See metafacture#308.
@dr0i dr0i requested a review from fsteeg September 30, 2019 14:56
@dr0i dr0i added the Flux label Sep 30, 2019
@dr0i dr0i assigned dr0i and fsteeg and unassigned dr0i Sep 30, 2019
@fsteeg
Copy link
Member

fsteeg commented Oct 1, 2019

Some flux test would be nice to verify that both commands still work, but we have no general place set up for flux tests, right?

@fsteeg fsteeg assigned dr0i and unassigned fsteeg Oct 1, 2019
@dr0i
Copy link
Member Author

dr0i commented Oct 24, 2019

Yes, we have no flux tests. However, calling flux.sh brings up two implementations of org.metafacture.xml.SimpleXmlEncoder. Also, copying the one example using the old flux command (MARC21-EDM.flux) to a new one which uses the new command encode-xml shows: both are good and results are the same.
As discussed, will update this MARC21-EDM.flux to use the new command as reference for future usage.

@dr0i dr0i assigned fsteeg and unassigned dr0i Oct 24, 2019
@fsteeg fsteeg assigned dr0i and unassigned fsteeg Oct 24, 2019
@dr0i dr0i merged commit 201c1b9 into metafacture:master Oct 24, 2019
@dr0i dr0i deleted the 308-addEncodeXmlToFluxCommands branch October 24, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants