Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from travis to github actions to test build #352

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Jan 14, 2021

Note that the .travis.yml is deliberately not removed as it does more
than just testing the build.

  • update badge in README

See #351.

@dr0i dr0i requested a review from fsteeg January 14, 2021 16:49
@dr0i dr0i self-assigned this Jan 14, 2021
@dr0i dr0i force-pushed the 351-migrateFromTravisToGithubActionsToTestBuild branch from c8e99c6 to 2ac0667 Compare January 15, 2021 07:57
@dr0i dr0i removed the request for review from fsteeg January 15, 2021 08:16
@dr0i
Copy link
Member Author

dr0i commented Jan 15, 2021

@dr0i dr0i requested review from fsteeg and removed request for fsteeg January 15, 2021 16:55
dr0i added 2 commits January 18, 2021 15:50
Note that the .travis.yml is deliberately not removed as it does more
than just testing the build.

- update badge in README

See #351.
- show only master branch badge

Complements 2ac0667.
@dr0i dr0i force-pushed the 351-migrateFromTravisToGithubActionsToTestBuild branch from 4554abf to c9b5d3d Compare January 18, 2021 14:51
@dr0i dr0i requested a review from fsteeg January 18, 2021 14:52
@dr0i
Copy link
Member Author

dr0i commented Jan 18, 2021

@fsteeg : I fixed the wrong reference in the commit message and force pushed. This is now review-ready.

@dr0i dr0i assigned fsteeg and unassigned dr0i Jan 18, 2021
@fsteeg
Copy link
Member

fsteeg commented Jan 19, 2021

Hm, so you mentioned leaving the travis.yml in place since it does more. But then this is not done yet, right?

@fsteeg fsteeg assigned dr0i and unassigned fsteeg Jan 19, 2021
@dr0i
Copy link
Member Author

dr0i commented Jan 19, 2021

The issue is about migrating the "test build", which the PR resolves using github actions.
At travis is more done, trying there to prepare release workflow. Which is not working anymore, anyhow.
We could a) create a new issue where this could be resolve or discussed if it should be resolved or b) remove that functionality altogether here by removing .travis.yml.
What do you think?

@dr0i dr0i assigned fsteeg and unassigned dr0i Jan 19, 2021
@fsteeg
Copy link
Member

fsteeg commented Jan 19, 2021

Right, maybe we should create a new issue. As far as I understand, there are 3 additional things done in the Travis build:

We could discuss in the new issue which of these we want, and how to implement them.

@dr0i
Copy link
Member Author

dr0i commented Jan 21, 2021

@fsteeg: I created 3 new issues for implementing 1. SonarCloud checks, 2. building release and 3. publish the release to Central.
So I think you can go on review this issue .

@dr0i dr0i assigned fsteeg and unassigned dr0i Jan 21, 2021
@fsteeg fsteeg assigned dr0i and unassigned fsteeg Jan 21, 2021
@dr0i dr0i merged commit b6e740c into master Jan 21, 2021
@dr0i dr0i deleted the 351-migrateFromTravisToGithubActionsToTestBuild branch January 21, 2021 16:58
blackwinter pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants