-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action "publish to github packages" #473
Conversation
Todo: update documentation in the wiki. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! But it should be published to the Metafacture registry, not your personal one.
By invoking "./gradlew publish" new github packages will be build and published. - update README - update build.gradle - remove superflous task - remove unused travis configs See metafacture-fix#265.
279a9e6
to
bb7e3cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'm a bit confused here. The version is Before, I had it set up (not in master, I used these only for OERSI) to release only when we push to an RC branch, and use that simple branch name as the version. See 6613de9 (based on the original setup in 8d762ea). Resulting in versions like |
TBH, I wasn't expecting this either, but it's a side effect of the "sophisticated" version logic in metafacture-core. My suggestion would be to drop it and simply rely on explicit version numbers (as in metafacture-fix). |
…of github.com:metafacture/metafacture-core
…of github.com:metafacture/metafacture-core
Use plain RC branch name as version during build. See #356
Thx @fsteeg , cherry-picked your solution. |
By pushing to a "publish" branch this branch will be build and published to github packages.
See metafacture-fix#265.