Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment count before starting new file in ObjectFileWriter #501

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Increment count before starting new file in ObjectFileWriter #501

merged 1 commit into from
Oct 5, 2023

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Oct 5, 2023

To avoid overwriting first output file, e.g. when using batch-reset (ObjectBatchResetter).

Noticed in our RPB workflows, where the first batch is overwritten by the second (e.g. here).

@fsteeg
Increment count before starting new file in ObjectFileWriter
b45391a 
To avoid overwriting first output file, e.g. when using batch-reset
@fsteeg fsteeg requested a review from dr0i October 5, 2023 11:39
@dr0i dr0i assigned fsteeg and unassigned dr0i Oct 5, 2023
@fsteeg fsteeg merged commit 4bfe2d0 into master Oct 5, 2023
1 check passed
@fsteeg fsteeg deleted the fixCountOnFileWriterReset branch October 5, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0i dr0i dr0i approved these changes

Assignees

@fsteeg fsteeg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsteeg @dr0i