Write valid leader without counting #527 #547
Conversation
Instead of just appending the incoming leader elements, this adds the static values for Pos: 00-04, 10-16, 20-23. By using `0`as default value for Pos: 00-04 and 12-16. #527 (comment)
TobiasNx
force-pushed
the
527-output-valid-leader
branch
from
ea05347 to
a0f2736
Compare
|
What's the point of doing the "easy" solution now that we already have the "hard" solution? |
|
The leader is always valid? |
|
I will put this on hold, the failing test hints that it is not as easy: issue336_createRecordWithTopLevelLeader_defaultMarc21Xml |
…ithub.com:metafacture/metafacture-core
If the incoming leader is 8 Metafacture is now able to create correct leaders for marc xml with static default values.
@blackwinter how would I tie my adjustments to |
|
What's the actual use case here? When would this change apply in practice? Because the implementation gets complicated by the fact that the setting for |
|
Always create valid marc xml records from marc binary besides the option to create correct calculate records. |
|
So binary MARC always has a leader of length 8, is that what you're saying? Or only in their case? |
Instead of just appending the incoming leader elements by
encode-marcmxl, this adds the static values for Pos: 00-04, 10-16, 20-23.By using
0as default value for Pos: 00-04 and 12-16.#527 (comment)