-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
497-improve-xml-documentation #563
Conversation
metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java
Outdated
Show resolved
Hide resolved
metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java
Outdated
Show resolved
Hide resolved
metafacture-xml/src/main/java/org/metafacture/xml/SimpleXmlEncoder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestions.
There's no space between text chunks ( |
I am not sure that I understand what I should do. But |
You're concatenating strings without adding any whitespace between them. You chose unfortunate examples, here's a better one. |
metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java
Outdated
Show resolved
Hide resolved
By @dr0i Co-authored-by: Pascal Christoph <christoph@hbz-nrw.de>
metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java
Outdated
Show resolved
Hide resolved
As suggested by @blackwinter
Thanks done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference: You can inspect the resulting documentation with ./gradlew fluxCommands
.
Resolves #497
We decided to improve the documentation.