Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation that decode-marc21 needs UTF-8 encoding #23

Closed
TobiasNx opened this issue Jun 10, 2022 · 2 comments
Closed

Add documentation that decode-marc21 needs UTF-8 encoding #23

TobiasNx opened this issue Jun 10, 2022 · 2 comments
Assignees
@dr0i

Comments

@TobiasNx
Copy link
Collaborator

See error here

https://github.com/metafacture/metafacture-documentation/blob/master/flux-commands.md

Other decoder as decode-aseq and decode-mab have documented that they need UTF-8 but decode-marc has not. So where do we have to document this?
@dr0i
Copy link
Member

dr0i commented Jun 10, 2022

Agreed to add to document UTF-8.
After metafacture/metafacture-core#452 is resolved it could also be USMARC , so I would postpone this issue and resolve it after metafacture/metafacture-core#452 is resolved.

dr0i added a commit to metafacture/metafacture-core that referenced this issue Jun 23, 2022
@dr0i
Add description: decode-marc21 needs UTF-8 encoding
45da349 
See metafacture/metafacture-documentation#23.
dr0i added a commit that referenced this issue Jun 23, 2022
@dr0i
Add description: decode-marc21 needs UTF-8 encoding (#23)
1c5a1eb
@dr0i
Copy link
Member

dr0i commented Jun 23, 2022

Skipped the USMARC part.
Added UTF-8 encoding to description, see https://github.com/metafacture/metafacture-documentation/blob/master/flux-commands.md#decode-marc21.
Closing.

@dr0i dr0i closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0i dr0i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dr0i @TobiasNx