Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build new with UNIX #16

Open
TobiasNx opened this issue Nov 8, 2023 · 10 comments · Fixed by #17
Open

Build new with UNIX #16

TobiasNx opened this issue Nov 8, 2023 · 10 comments · Fixed by #17
Assignees

Comments

@TobiasNx
Copy link

TobiasNx commented Nov 8, 2023

Analog to metafacture/metafacture-fix#315

The flux extension should be build newly with UNIX and it should be documented, that it should be only build with UNIX.

@katauber
Copy link
Member

katauber commented Nov 9, 2023

functional review: @TobiasNx

@katauber katauber moved this to Selected in Metafacture Nov 9, 2023
@TobiasNx
Copy link
Author

TobiasNx commented Nov 9, 2023

This also has a bug:
grafik

@katauber katauber moved this from Selected to Working in Metafacture Nov 10, 2023
@katauber
Copy link
Member

I'm a little bit stuck here. When I run ./gradlew installServer, it always fails. I tried many different things, but it doesn't work and I don't know why. @fsteeg could you please try to build the extension? At the moment I'm not sure, if this is a problem with my subsystem.

@fsteeg
Copy link
Member

fsteeg commented Nov 29, 2023

@fsteeg could you please try to build the extension?

Works for me (with Java 11 and Node 14).

@katauber
Copy link
Member

Works for me (with Java 11 and Node 14).

Java 11 was the solution! (I tried different versions but not 11) Thank you.

katauber added a commit that referenced this issue Nov 30, 2023
@katauber katauber assigned fsteeg and unassigned katauber Nov 30, 2023
@katauber katauber moved this from Working to Review in Metafacture Nov 30, 2023
@fsteeg
Copy link
Member

fsteeg commented Nov 30, 2023

Tested vsix file created by @katauber, looks good, no error output, and getting sensible suggestions in editor.

+1

@fsteeg fsteeg assigned katauber and unassigned fsteeg Nov 30, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in Metafacture Dec 1, 2023
@TobiasNx TobiasNx reopened this Dec 2, 2024
@TobiasNx
Copy link
Author

TobiasNx commented Dec 2, 2024

This seems not to be fully fixed, in contrast to the fix extension the flux extension only works IF Java 11 is running and set as the running Java version with . But Metafacture also is running with Java 17 even 21.

@fsteeg
Copy link
Member

fsteeg commented Dec 2, 2024

Since this is a separate repo / build I don't think this is a problem. The GitHub action is properly configured and includes deployment to metafacture.github.io.

@TobiasNx
Copy link
Author

TobiasNx commented Dec 2, 2024

When Java 11 is set in java config upon starting the extension in VS Code:
grafik

When Java 17 is set in Java config upon starting the extension in VS Code:
grafik

@fsteeg
Copy link
Member

fsteeg commented Dec 2, 2024

Ah, when using the extension in VS code, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants