Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_ in example names are turned into whitespaces/+ in links #153

Closed
TobiasNx opened this issue Nov 23, 2023 · 5 comments · Fixed by #154
Closed

_ in example names are turned into whitespaces/+ in links #153

TobiasNx opened this issue Nov 23, 2023 · 5 comments · Fixed by #154
Assignees
@katauber

Comments

@TobiasNx
Copy link
Contributor

grafik

https://metafacture.org/playground/?example=add+field

resources/examples/Fixes/add_field

If fixed also the Playground Links in the metafacture fix readme need to be updated.
@blackwinter blackwinter mentioned this issue Nov 23, 2023
Merged
@blackwinter
Copy link
Member

Treated as blocker for metafacture/metafacture-fix#339.

@dr0i dr0i added this to Metafacture Nov 24, 2023
@dr0i dr0i moved this to Ready in Metafacture Nov 24, 2023
@katauber katauber moved this from Ready to Working in Metafacture Nov 24, 2023
katauber added a commit that referenced this issue Nov 24, 2023
@katauber
Use + instead of _ to mark whitespaces in examples. See #153
a639b5e
@katauber
Copy link
Member

Deployed to https://test.metafacture.org/playground/
Who's going to functional review this @dr0i @blackwinter?

@katauber katauber moved this from Working to Review in Metafacture Nov 24, 2023
@katauber katauber removed their assignment Nov 24, 2023
@katauber katauber mentioned this issue Nov 24, 2023
Merged
@blackwinter
Copy link
Member

LGTM, thanks!

@dr0i
Copy link
Member

dr0i commented Nov 27, 2023

LGTM also.

@github-project-automation github-project-automation bot moved this from Review to Done in Metafacture Nov 28, 2023
@katauber
Copy link
Member

Deployed to https://metafacture.org/playground/

blackwinter added a commit to metafacture/metafacture-fix that referenced this issue Nov 28, 2023
@blackwinter
Fix example links. (#339)
ec0b2fe 
Now that metafacture/metafacture-playground#153 has been resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katauber katauber

Labels
None yet
Projects
Metafacture
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use + instead of _ to mark whitespaces in examples metafacture/metafacture-playground
4 participants
@blackwinter @dr0i @TobiasNx @katauber