Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process all examples as integration tests #132

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Conversation

katauber
Copy link
Member

All examples are processed. If there is any exception, the tests will fail.
Closes #121

@katauber katauber requested a review from fsteeg September 13, 2023 07:30
@katauber
Copy link
Member Author

lein test is executed in the Github Actions, so on every push all examples will be processed

@fsteeg
Copy link
Member

fsteeg commented Sep 13, 2023

Here's what I noticed:

  • It seems only the top-level examples are tested, not those in the experimental and workshop folders
  • It would be nice to print the filenames of the examples to understand what's actually tested
  • What's tested is just that they can be processed without throwing exceptions, right? Perhaps we could test a bit more, e.g. that the result is non-empty?

I gave it a go in 6b96c01, hope it's idiomatic.

We might even want to add the expected result as a second line to the examples, so we can compare the results?

@fsteeg fsteeg assigned katauber and unassigned fsteeg Sep 13, 2023
@katauber
Copy link
Member Author

katauber commented Sep 21, 2023

I gave it a go in 6b96c01, hope it's idiomatic.

I moved the log message to when the example is really executed

We might even want to add the expected result as a second line to the examples, so we can compare the results?

I would like to see this in another issue, so we can merge this pull request :)

@katauber katauber assigned fsteeg and unassigned katauber Sep 21, 2023
@fsteeg fsteeg assigned katauber and unassigned fsteeg Sep 22, 2023
@katauber katauber merged commit 9599eba into main Sep 22, 2023
@katauber katauber deleted the 121-examplesAsTests branch September 22, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute all examples as integration tests
2 participants