Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: use SHELL as executable #65

Closed
metaist opened this issue Aug 19, 2024 · 2 comments
Closed

add: use SHELL as executable #65

metaist opened this issue Aug 19, 2024 · 2 comments

Comments

@metaist
Copy link
Owner

metaist commented Aug 19, 2024

For example, if you're running ds from bash, then subprocess.run should use bash.
@metaist
Copy link
Owner Author

metaist commented Aug 26, 2024

For windows check COMSPEC.

metaist added a commit that referenced this issue Aug 28, 2024
@metaist
update: detect current shell on windows (#65)
1b8d589
@metaist
Copy link
Owner Author

metaist commented Sep 2, 2024

HT @lshkap613 turns out COMSPEC on PowerShell on Windows is set to cmd.exe which prevents things from running correctly.

@metaist metaist reopened this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metaist