fix: run companies update only when mail is the option

metakgp · Nov 27, 2024 · 73a87bf · 73a87bf
1 parent 5d593d2
commit 73a87bf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/mftp/env.example.py b/mftp/env.example.py
@@ -15,8 +15,8 @@
 MONGO_URI = f'mongodb://{MONGO_ROOT_USERNAME}:{MONGO_ROOT_PASSWORD}@db:{MONGO_PORT}'
 MONGO_COLLECTION = "AY_2024-25"
 
-# EMAIL (via SMTP)
-## Senders' Credentials
+# EMAIL
+## Senders' Credentials (via SMTP)
 FROM_EMAIL = "abc@gmail.com" # Notification Sender Email-id
 FROM_EMAIL_PASS = "**********" # App password for the above email-id
 ## EMAIL - Receiver's Address

diff --git a/mftp/mftp.py b/mftp/mftp.py
@@ -35,12 +35,13 @@
   print('[ERP LOGIN]', flush=True)
   _, ssoToken = erp.login(headers, session, ERPCREDS=env, OTP_CHECK_INTERVAL=2, LOGGING=True, SESSION_STORAGE_FILE='.session')
 
-  if now - last_companies_email_time >= timedelta(hours=1):
-    companies = company.fetch(session, headers, ssoToken)
-    open_not_applied_companies = company.filter(companies, "OPEN_N")
-    companies_update_mail = mail.format_companies(session.cookies.get('ssoToken'), open_not_applied_companies)
-    mail.send_companies(companies_update_mail, args.gmail_api, args.smtp)
-    last_companies_email_time = now
+  if args.gmail_api or args.smtp:
+    if now - last_companies_email_time >= timedelta(hours=1):
+      companies = company.fetch(session, headers, ssoToken)
+      open_not_applied_companies = company.filter(companies, "OPEN_N")
+      companies_update_mail = mail.format_companies(session.cookies.get('ssoToken'), open_not_applied_companies)
+      mail.send_companies(companies_update_mail, args.gmail_api, args.smtp)
+      last_companies_email_time = now
 
   notice_db = db.NoticeDB(config={
     'uri': env.MONGO_URI,