Implements all of the Alloy components #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogomatsubara
requested changes
Jul 19, 2022
There was a problem hiding this comment.
Thanks for the work on this @joelrebel !
I have a few comments and a more general clarification.
It's my understanding there are two main cases for use alloy. First case is to use alloy as part of the deprovisioning process to collect hardware inventory (inband).
The second case is to use alloy as a standalone tool that collects hardware inventory for the whole fleet (oob).
It seems to me that this code is optimised for the second case due to its concurrency aspects. Is this the correct understanding?
diogomatsubara
approved these changes
Aug 2, 2022
joelrebel
added a commit
that referenced
this pull request
Aug 29, 2022
* docs: Add README, development notes * examples: add sample config, image assets * Update Makefile, CI linter, pull request template * internal/model: define Asset, AssetDevice, Config structs * app: App holds attributes to initialize Alloy * internal/asset: Asset getter interface and csv implemention * internal/fixtures: add emapi getter mock implementation * internal/asset/emapi: emapi asset getter implementation * internal/collect: define interface, errors * internal/fixtures: add device mock data, returned by a collector * internal/fixtures: add out of band fixture data for tests * internal/fixtures: add inband fixture data for tests * internal/collect/inband: implement inband inventory collector * internal/collect/inband: implement out of band inventory collector * internal/fixtures: add asset getter mock implementation * internal/publish: define interface and implement stdout publisher * internal/publisher: implement hollow publisher * internal/fixtures: add hollow service mock data * cmd: cli commands and inband cli command * cmd/outofband: implement outofband cli command * purge bin file * docs: a directory for docs and related files * .gitignore: ignore alloy binary * cmd/outofband: follow camelcase convention for struct name * replace all references and variable names from hollow to serverService * clear unused global vars and add proper method comments * go: update to upstream bmclib v2 release; switch to Go 1.18 * CI: update dockerfile for alloy inband build * ci: disable CODEQL scanning until repository is public * ci: build alloy docker image as alloy-inband * README: stick with short flag options in the examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Alloy itself to function as an inventory collector - for both
inband, andout of banddata collection.To understand how the changes included come together, have a look at
README-development.md
README.md
The changes included basically implements,
inband,outofbandAsset getter,Inventory collector,Inventory publisher,the components function together to collect and publish hardware inventory.
TODO: