Silence unnecessary warning in CollectFirmwareChecksums #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing the following when trying to run vogelkop disk wipe: ``` INFO[0000] error collecting BIOS Logo checksum error="reading firmware binary image: cmd /nix/store/d01i7vhwh0fjj5pf6q2dna1qr3pbw5zj-flashrom-1.3.0/bin/flashrom -p internal --ifd -i bios -r /tmp/bios_checksum/bios_img.bin exited with error: FCH device found but SMBus revision 0x61 does not match known values.\nPlease report this to flashrom@flashrom.org and include this log and\nthe output of lspci -nnvx, thanks!.\nCould not determine chipset generation.\n\t exitCode: 1\n\t stdout: flashrom v1.3.0 on Linux 6.8.7 (x86_64)\nflashrom is free software, get the source code at https://flashrom.org\n\nUsing clock_gettime for delay loops (clk_id: 1, resolution: 1ns).\nFound chipset \"AMD FP4\".\nEnabling flash write... PROBLEMS, continuing anyway\nNo EEPROM/flash device found.\nNote: flashrom can never write if the flash chip isn't found automatically.\n" ``` Seeing as both flashrom and ironlib do not treat this as an error and we are already handling the error (by returning it) we should not also log it, leave that to the caller to decide.
mmlb
requested review from
joelrebel,
splaspood,
turegano-equinix and
DoctorVin
as code owners
joelrebel
approved these changes
Jun 26, 2024
mmlb
referenced
this pull request
in metal-toolbox/vogelkop
Jun 28, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/metal-toolbox/ironlib](https://togithub.com/metal-toolbox/ironlib) | `v0.2.18` -> `v0.3.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>metal-toolbox/ironlib (github.com/metal-toolbox/ironlib)</summary> ### [`v0.3.0`](https://togithub.com/metal-toolbox/ironlib/releases/tag/v0.3.0) [Compare Source](https://togithub.com/metal-toolbox/ironlib/compare/v0.2.18...v0.3.0) #### What's Changed - Silence unnecessary warning in CollectFirmwareChecksums by [@​mmlb](https://togithub.com/mmlb) in [https://github.com/metal-toolbox/ironlib/pull/165](https://togithub.com/metal-toolbox/ironlib/pull/165) - Add a loopback block device test for blkdiscard by [@​ScottGarman](https://togithub.com/ScottGarman) in [https://github.com/metal-toolbox/ironlib/pull/166](https://togithub.com/metal-toolbox/ironlib/pull/166) **Full Changelog**: metal-toolbox/ironlib@v0.2.18...v0.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/metal-toolbox/vogelkop). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Quiets down "error collectiong BIOS Logo checksum" error messages during inventory action.
The HW vendor this change applies to (if applicable)
Any where flashrom errors while trying to get the logo checksums, for example:
How can this change be tested by a PR reviewer?
Run it on a machine w/o a bios that flashrom can interrogate and see no errors logged.