Update requirements getter #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce method parameters to necessary
enables clients to call check for any update requirements for a component before proceeding with an update
joelrebel
requested review from
mmlb,
splaspood,
turegano-equinix and
DoctorVin
as code owners
jakeschuurmans
approved these changes
Aug 14, 2024
jakeschuurmans
previously approved these changes
Aug 14, 2024
instead of a copy of the struct
joelrebel
dismissed stale reviews from DoctorVin and jakeschuurmans
via
fab996e
DoctorVin
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
actions/UpdateComponentto allow callers to target a specific component.ErrRebootRequiredwhen the nic indicates a reboot is necessary to proceed.Getterinterface forDeviceManagerto expose querying the update requirements.Note: CI pipeline fails on building the image because of a linux.dell.com failure https://github.com/metal-toolbox/ironlib/actions/runs/10387458487/job/28760980470#step:8:478