go: dep changes #303
joelrebelAnnotations
10 errors and 3 warnings
|
lint-test:
events/controller/status_test.go#L157
Error return value of `kv.Put` is not checked (errcheck)
|
|
lint-test:
events/controller/status_test.go#L164
Error return value of `kv.Put` is not checked (errcheck)
|
|
lint-test:
events/controller/status_test.go#L176
Error return value of `kv.Put` is not checked (errcheck)
|
|
lint-test:
events/controller/controller.go#L304
importShadow: shadow of imported from 'github.com/metal-toolbox/rivets/condition' package 'condition' (gocritic)
|
|
lint-test:
events/controller/controller.go#L336
importShadow: shadow of imported from 'github.com/metal-toolbox/rivets/condition' package 'condition' (gocritic)
|
|
lint-test:
events/controller/metrics.go#L50
importShadow: shadow of imported from 'github.com/metal-toolbox/rivets/condition' package 'condition' (gocritic)
|
|
lint-test:
events/controller/status_test.go#L187
err113: do not compare errors directly "err == nats.ErrKeyNotFound", use "errors.Is(err, nats.ErrKeyNotFound)" instead (goerr113)
|
|
lint-test:
events/controller/config.go#L27
mnd: Magic number: 60, in <assign> detected (gomnd)
|
|
lint-test:
events/controller/config.go#L35
mnd: Magic number: 5, in <assign> detected (gomnd)
|
|
lint-test:
events/controller/config.go#L40
mnd: Magic number: 5, in <assign> detected (gomnd)
|
|
lint-test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, actions/checkout@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint-test:
events/controller/status.go#L170
unexported-return: exported method ConditionState returns unexported type controller.conditionState, which can be annoying to use (revive)
|
|
lint-test
Restore cache failed: Dependencies file is not found in /home/runner/work/rivets/rivets. Supported file pattern: go.sum
|