🌱 adopt manifests for kustomize v5

[LittleChimera]

What this PR does / why we need it:

building kustomize layers with kustomize v5 outputs warnings of deprecation

$ kustomize build default/ > render/capm3.yaml 
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

[metal3-io-bot]

Hi @LittleChimera. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tuminoid]

/ok-to-test

[tuminoid]

Possibly related: #1304
/cc @lentzi90

[lentzi90]

Thanks for working on this!
I have been working upstream with kustomize and kubebuilder in kubernetes-sigs/kustomize#5049 and kubernetes-sigs/kubebuilder#3539 to get this fixed at the source. I believe we will end up removing the CA injection patches and just rely on replacements to set the annotations. However, I'm happy to take this in while still figuring out the details upstream. (We don't have the issue of multiple patches in one file, since we have the mutating webhook patch commented out.) When we reach a conclusion upstream I will also try to propagate it here to keep things consistent.

/lgtm

[lentzi90]

A note for the future: This one will work as it is, but if we at some point want to enable to mutating webhook (which is now in the same file but commented out) then it will break as long as kubernetes-sigs/kustomize#5049 is unresolved.
It is easy to fix though so no need to worry about it. Just split the patch into two files.

[lentzi90]

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

[LittleChimera]

@lentzi90 seems like you also solved the same issue in your PR. If you're close to merging, it's probably easier to just close this one. Thanks for the quick response 🙏

[lentzi90]

No no I'm happy to take this. This will make it easier for me to progress with what I was actually trying to do, i.e. reorganize and add Kustomize Components 🙂

[LittleChimera]

Can we merge this?

[lentzi90]

Yes let's get an approver to look at it!
/assign @kashifest

[kashifest]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment