Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add redfish_https interface #1954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Add redfish_https interface #1954

wants to merge 1 commit into from

Conversation

derekhiggins
Copy link
Member

@derekhiggins derekhiggins commented Sep 12, 2024 •
edited
Loading

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2024
@hroyrh
Copy link
Member

hroyrh commented Sep 12, 2024

/lgtm

@metal3-io-bot
Copy link
Contributor

@hroyrh: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@derekhiggins derekhiggins changed the title Add redfish_https interface ✨ Add redfish_https interface Sep 13, 2024
derekhiggins
derekhiggins commented Sep 13, 2024
View reviewed changes
pkg/hardwareutils/bmc/access_test.go Outdated
@@ -432,6 +432,18 @@ func TestStaticDriverInfo(t *testing.T) {
power: "",
},

{
Scenario: "redfish uefi http boot",
input: "redfish-https+https://192.168.122.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, according to the design doc I should have called this redfish-uefihttp
https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/uefi-http-boot.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's use that name: redfish-https+https will be confused with redfish+https for sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does PR title needs update then as well?

@derekhiggins
Copy link
Member Author

/hold
see inline comment

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2024
@derekhiggins derekhiggins mentioned this pull request Sep 16, 2024
Open
@derekhiggins
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2024
Rozzii
Rozzii reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@derekhiggins
Add redfish_https interface
cd1827d 
Add new interface to allow UefiHttp boot.

Signed-off-by: Derek Higgins <derekh@redhat.com>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@metal3-io-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

@s3rj1k s3rj1k Awaiting requested review from s3rj1k

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@derekhiggins @metal3-io-bot @hroyrh @dtantsur @tuminoid @Rozzii